Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(index): don't use prod libs in dev #2216

Merged
merged 1 commit into from
Oct 19, 2017
Merged

Conversation

levithomason
Copy link
Member

This explains why prop type warnings were being swallowed in local development, we were using production libs in local development.

This PR adds the prod flag for all CDN libs, not just React.

@codecov-io
Copy link

Codecov Report

Merging #2216 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2216   +/-   ##
=======================================
  Coverage   99.73%   99.73%           
=======================================
  Files         151      151           
  Lines        2624     2624           
=======================================
  Hits         2617     2617           
  Misses          7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a29f6c...b8dace6. Read the comment docs.

@levithomason levithomason merged commit 470c7b5 into master Oct 19, 2017
@levithomason levithomason deleted the fix/docs-index branch October 19, 2017 06:01
@levithomason
Copy link
Member Author

Released in semantic-ui-react@0.76.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants